(moved from SupportForum)

I really like this wiki engine, but I am a little concerned about the need for call-time pass-by-reference. Are there any plans to eliminate the need for having call-time pass-by-reference set to On? I'm afraid to deploy this on my server if it will not play nice with future versions of PHP.

Best, Matt

milky: Hey Matt! I'm sure we don't have call-time-pass-by-ref anywhere in the code. Variables are passed a lot by reference (mainly for speed advantage), but the variable pass-by-ref & is always (and only) in the function definitions, so it does not depend on the mentioned PHP setting.

If there is somewhere a variable relly passed by reference like my_func(&$varname) then this is clearly a bug, but then an easy to work out one. I'm checking the code base immediately... ;-)

Matt: Well, this is one of the error messages I am trying to fix.

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of *runtime function name(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in c:\inetpub\wwwroot\wiki\ewiki.php on line 1811

This line definately shows a pass by reference. There were two more, but I did a quick hack to get passed those, but I can not figure out what that line is exactly doing.

Thanks for the help,

milky: Thanksf for the note, I've removed the one & you've found here, it is very redundant there (you can safely remove it). However I didn't found anything else. Where have you seen the other two occourences?

milky: Ok, found the other two (grep missed them), they were likewise redundant there (but this time, not my fault!! ;)

Matt: Sorry to keep bothering you, but are the files that you have amended available for download? Thanks so much for your quick response. You have been great.

milky: No, you don't bother me at all. I'm really thankful for your note about that, because I didn't notice this myself. For the code: I uploaded it yesterday afternoon into CVS, therefore it should have appeared in the CVS-tarball now. But there is really nothing new in it, and you've already fixed it correctly I think. (I try to keep an eye on such bugs in future, I swear ;)